Java glacier2 callback #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Java Glacier2 callback demo that demonstrates how to establish a session with a Glacier2 router and implement callbacks through the router.
- Implementation of a complete Glacier2 callback demo with client-server architecture
- Client establishes a bidirectional connection through Glacier2 router for callbacks
- Server provides wake-up service that calls back to the client's alarm clock implementation
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| java/Glacier2/callback/slice/AlarmClock.ice | Defines Slice interfaces for AlarmClock callback and WakeUpService |
| java/Glacier2/callback/settings.gradle.kts | Gradle settings configuring multi-project build with client/server modules |
| java/Glacier2/callback/server/src/main/java/com/example/glacier2/callback/server/SimpleWakeUpService.java | Server-side service implementation that schedules and executes alarm callbacks |
| java/Glacier2/callback/server/src/main/java/com/example/glacier2/callback/server/Server.java | Main server application with Ice communicator and object adapter setup |
| java/Glacier2/callback/server/build.gradle.kts | Server module build configuration with Slice compilation |
| java/Glacier2/callback/gradlew.bat | Gradle wrapper script for Windows |
| java/Glacier2/callback/gradlew | Gradle wrapper script for Unix-like systems |
| java/Glacier2/callback/gradle/wrapper/gradle-wrapper.properties | Gradle wrapper configuration |
| java/Glacier2/callback/config.glacier2 | Glacier2 router configuration file |
| java/Glacier2/callback/client/src/main/java/com/example/glacier2/callback/client/MockAlarmClock.java | Client-side AlarmClock implementation for callback handling |
| java/Glacier2/callback/client/src/main/java/com/example/glacier2/callback/client/Client.java | Main client application with Glacier2 session management |
| java/Glacier2/callback/client/build.gradle.kts | Client module build configuration |
| java/Glacier2/callback/README.md | Documentation explaining the demo architecture and usage |
| java/Glacier2/callback/.gitignore | Git ignore file for build artifacts |
java/Glacier2/callback/README.md
Outdated
|
|
||
| > [!TIP] | ||
| > You can also start the Glacier2 router before the server. The order does not matter: the server is identical to the | ||
| > server provided in the [Ice Greeter][1] demo and does not depend on Glacier2. |
There was a problem hiding this comment.
The reference to 'Ice Greeter' demo is incorrect. Based on the context, this should reference the 'Ice Callback' demo since this Glacier2 demo is similar to the Ice Callback demo mentioned at the beginning.
Suggested change
| > server provided in the [Ice Greeter][1] demo and does not depend on Glacier2. | |
| > server provided in the [Ice Callback][1] demo and does not depend on Glacier2. |
Comment on lines
+56
to
+57
| [1]: ../callback | ||
| [2]: ../bidir |
There was a problem hiding this comment.
The link references are inconsistent with their usage in the document. Reference [1] is used for both 'Ice Callback' and 'Ice Greeter', but they point to different demos. The reference on line 46 should use [2] for 'Ice Greeter' or the text should be corrected to reference 'Ice Callback'.
bernardnormier
approved these changes
Sep 26, 2025
| } catch (InterruptedException | ExecutionException ex) { | ||
| System.err.println(ex); | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.